From 31d07ae72c3b78936bd4a385f1f5a72a2171da8b Mon Sep 17 00:00:00 2001 From: Christophe Priouzeau Date: Wed, 29 Mar 2023 14:46:04 +0200 Subject: [PATCH 17/17] sts/3801>gtkwaylandsink: Destroy GstWlWindow when parent GtkWindow is destroyed Part-of: --- ext/gtk/gstgtkwaylandsink.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ext/gtk/gstgtkwaylandsink.c b/ext/gtk/gstgtkwaylandsink.c index e32bbcc..9691255 100644 --- a/ext/gtk/gstgtkwaylandsink.c +++ b/ext/gtk/gstgtkwaylandsink.c @@ -961,6 +961,9 @@ gst_gtk_wayland_sink_set_caps (GstBaseSink * bsink, GstCaps * caps) if (!gst_wl_display_check_format_for_dmabuf (priv->display, format)) goto unsupported_format; } else if (!gst_wl_display_check_format_for_shm (priv->display, format)) { + /* Note: we still support dmabuf in this case, but formats must also be + * supported on SHM interface to ensure a fallback is possible as we are + * not guarantied we'll get dmabuf in the buffers. */ goto unsupported_format; } -- 2.25.1